On Tue, May 01, 2018 at 11:53:24AM +0200, Hans de Goede wrote: > Hi, > > On 30-04-18 14:41, Heikki Krogerus wrote: > > The driver will not probe unless bq24190 is loaded, so > > making it a dependency. > > Hmm, the dependency is pure run-time, with this Kconfig > change if a user now decides to builtin the intel_cht_int33fe > driver, the bq24190 driver must also be builtin, I'm not sure > if that is a good thing. OK. That should be possible to sort out with something like this: depends on CHARGER_BQ24190=y || CHARGER_BQ24190=INTEL_CHT_INT33FE I'll fix this one. > > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> > > Cc: Darren Hart <dvhart@xxxxxxxxxxxxx> > > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > --- > > drivers/i2c/busses/Kconfig | 3 +-- > > drivers/platform/x86/Kconfig | 4 ++-- > > 2 files changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > > index 8d21b9825d71..fce9f2ca0570 100644 > > --- a/drivers/i2c/busses/Kconfig > > +++ b/drivers/i2c/busses/Kconfig > > @@ -202,8 +202,7 @@ config I2C_CHT_WC > > Note this controller is hooked up to a TI bq24292i charger-IC, > > combined with a FUSB302 Type-C port-controller as such it is advised > > - to also select CONFIG_CHARGER_BQ24190=m and CONFIG_TYPEC_FUSB302=m > > - (the fusb302 driver currently is in drivers/staging). > > + to also select CONFIG_TYPEC_FUSB302=m. > > config I2C_NFORCE2 > > tristate "Nvidia nForce2, nForce3 and nForce4" > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > > index 39d06dd1f63a..1dbd9d547e60 100644 > > --- a/drivers/platform/x86/Kconfig > > +++ b/drivers/platform/x86/Kconfig > > @@ -866,6 +866,7 @@ config ACPI_CMPC > > config INTEL_CHT_INT33FE > > tristate "Intel Cherry Trail ACPI INT33FE Driver" > > depends on X86 && ACPI && I2C && REGULATOR > > + depends on CHARGER_BQ24190 > > ---help--- > > This driver add support for the INT33FE ACPI device found on > > some Intel Cherry Trail devices. > > @@ -877,8 +878,7 @@ config INTEL_CHT_INT33FE > > i2c drivers for these chips can bind to the them. > > If you enable this driver it is advised to also select > > - CONFIG_TYPEC_FUSB302=m, CONFIG_CHARGER_BQ24190=m and > > - CONFIG_BATTERY_MAX17042=m. > > + CONFIG_TYPEC_FUSB302=m and CONFIG_BATTERY_MAX17042=m. > > config INTEL_INT0002_VGPIO > > tristate "Intel ACPI INT0002 Virtual GPIO driver" > > Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
