On Thu, Apr 26, 2018 at 11:22:25PM +0700, Lars Melin wrote: > On 4/26/2018 23:12, Johan Hovold wrote: > > On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote: > >> On 4/26/2018 18:39, Lars Melin wrote: > >>> On 4/26/2018 18:19, Bjørn Mork wrote: > >>>> Anyway, Qualcomm based designs are definitely handled by both drivers. > >>>> Using qcserial only makes sense if the interface layout matches one of > >>>> the defined shared schemes, which currently are: > >>>> > >>>> QCSERIAL_G2K = 0, /* Gobi 2000 */ > >>>> QCSERIAL_G1K = 1, /* Gobi 1000 */ > >>>> QCSERIAL_SWI = 2, /* Sierra Wireless */ > >>>> QCSERIAL_HWI = 3, /* Huawei */ > >>> > >>> It seems to me that this Quectel device matches the interface layout for > >>> Gobi1K: > > Yeah, but qcserial appears to select a different altsetting for the DM > > port for Gobi 1000, an altsetting which this particular device does not > > have. > > > > I didn't re-read the full thread I referred to earlier, but I think in > > it, Dan mentioned Gobi 1000 device requiring firmware to be loaded too. > > > > So if it's not a G1K device, we probably shouldn't be using qcserial > > even if the interface layout happens to match. > Good point, I forgot about the required firmware loading for Gobi1K. > So this device should be handled by the option driver. Yeah, we probably should document all of this at some point. :) I didn't include the patch in this weeks -rc updates, but I've queued it up for the next batch. Thanks everyone. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
