On Thursday 26 April 2018 11:23 AM, Sekhar Nori wrote:
> On Thursday 19 April 2018 01:35 AM, Bin Liu wrote:
>> The gadget function drivers should ensure the usb_request parameter
>> passed in is not NULL. UDC core doesn't check if it is NULL, so MUSB
>> driver shouldn't have to check it either.
>>
>> Convert to_musb_request() to a simple macro to not directly return NULL
>> to avoid warnings from code static analysis tools.
>>
>> Signed-off-by: Bin Liu <b-liu@xxxxxx>
>> ---
>> drivers/usb/musb/musb_gadget.h | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/musb/musb_gadget.h b/drivers/usb/musb/musb_gadget.h
>> index 9c34aca06db6..466877b471ef 100644
>> --- a/drivers/usb/musb/musb_gadget.h
>> +++ b/drivers/usb/musb/musb_gadget.h
>> @@ -60,10 +60,7 @@ struct musb_request {
>> enum buffer_map_state map_state;
>> };
>>
>> -static inline struct musb_request *to_musb_request(struct usb_request *req)
>> -{
>> - return req ? container_of(req, struct musb_request, request) : NULL;
>> -}
>> +#define to_musb_request(r) (container_of(r, struct musb_request, request))
>
> Unnecessary parens over container_of
And 'r' can actually be parenthesized for safety.
Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
