Am 23.04.2018 um 09:05 schrieb Grigor Tovmasyan:
Hi Stefan,
On 4/18/2018 1:11 AM, Stefan Wahren wrote:
Hi Grigor,
Grigor Tovmasyan <Grigor.Tovmasyan@xxxxxxxxxxxx> hat am 16. April 2018 um 12:16 geschrieben:
In dwc2_gadget_init() we allocate EP0 request via
dwc2_hsotg_ep_alloc_request(). After that there are
usb_add_gadget_udc() call and if it failed, then
ctrl_req will not be freed and will cause memory leak.
Reordered function calls in gadget_init: moved up usb_add_gadget_udc()
before dwc2_hsotg_ep_alloc_request().
i'm not sure, but doesn't this change introduce a race condition before EP0 request has been allocated?
As far as I know the firt request to EP0 coming when the function driver
first bind() to the device, which happens after dwc2 probe.
So, in my opinion this patch is safe.
okay fine
Grigor
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
