> -----Original Message----- > From: Tiago Brusamarello [mailto:tbrusa@xxxxxxxxx] > Sent: Thursday, April 19, 2018 6:58 AM > To: Leo Li <leoyang.li@xxxxxxx> > Cc: nikhil.badola@xxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx > Subject: [PATCH 1/1] drivers: usb: Introduce FSL_USB2_PHY_UTMI_DUAL for > usb gadget > > Introduce FSL_USB2_PHY_UTMI_DUAL in gadget driver for setting > phy in SOCs with utmi dual phy > > Signed-off-by: Nikhil Badola <mailto:nikhil.badola@xxxxxxxxxxxxx> [snip] > Change-Id: I2c53b89d9916bd17b5be8b5d9e32454943172d55 > Reviewed-on: > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit.a > m.freescale.net%3A8181%2F25528&data=02%7C01%7Cleoyang.li%40nxp.co > m%7C7e18a2921b7b43abb8db08d5a5ecc059%7C686ea1d3bc2b4c6fa92cd99c5 > c301635%7C0%7C0%7C636597358611709638&sdata=U3moxDqSc%2F576XLDS > qJLdfYhDJeccNLzF%2FWr%2BQv0bRU%3D&reserved=0 > Tested-by: Review Code-CDREVIEW <mailto:CDREVIEW@xxxxxxxxxxxxx> > Reviewed-by: Suresh Gupta <mailto:suresh.gupta@xxxxxxxxxxxxx> > Reviewed-by: Matthew Weigel <mailto:Matthew.Weigel@xxxxxxxxxxxxx> [/snip] The patch looks good. But we probably should remove the above internal information as they are not needed for upstream. > Tested-by: Tiago Brusamarello <mailto:tbrusa@xxxxxxxxx> Otherwise Acked-by: Li Yang <leoyang.li@xxxxxxx> > --- > drivers/usb/gadget/udc/fsl_udc_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c > b/drivers/usb/gadget/udc/fsl_udc_core.c > index 56b517a..a3c092b 100644 > --- a/drivers/usb/gadget/udc/fsl_udc_core.c > +++ b/drivers/usb/gadget/udc/fsl_udc_core.c > @@ -253,6 +253,7 @@ static int dr_controller_setup(struct fsl_udc *udc) > portctrl |= PORTSCX_PTW_16BIT; > /* fall through */ > case FSL_USB2_PHY_UTMI: > + case FSL_USB2_PHY_UTMI_DUAL: > if (udc->pdata->have_sysif_regs) { > if (udc->pdata->controller_ver) { > /* controller version 1.6 or above */ > -- > 2.7.4 ��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥