> -----Original Message----- > From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: 2018年4月16日 22:28 > To: Jun Li <jun.li@xxxxxxx> > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; heikki.krogerus@xxxxxxxxxxxxxxx; > linux@xxxxxxxxxxxx; a.hajda@xxxxxxxxxxx; shufan_lee@xxxxxxxxxxx; Peter > Chen <peter.chen@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx; > linux-usb@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; > devel@xxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v4 02/13] dt-bindings: usb: add documentation for typec > port controller(TCPCI) > > On Mon, Apr 16, 2018 at 6:54 AM, Jun Li <jun.li@xxxxxxx> wrote: > > Hi > >> -----Original Message----- > >> From: Rob Herring [mailto:robh@xxxxxxxxxx] > >> Sent: 2018年4月10日 4:04 > >> To: Jun Li <jun.li@xxxxxxx> > >> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; heikki.krogerus@xxxxxxxxxxxxxxx; > >> linux@xxxxxxxxxxxx; a.hajda@xxxxxxxxxxx; shufan_lee@xxxxxxxxxxx; > >> Peter Chen <peter.chen@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx; > >> linux-usb@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; > >> devel@xxxxxxxxxxxxxxxxxxxx > >> Subject: Re: [PATCH v4 02/13] dt-bindings: usb: add documentation for > >> typec port controller(TCPCI) > >> > >> On Thu, Mar 29, 2018 at 12:06:07AM +0800, Li Jun wrote: > > [...] > > >> > +ptn5110@50 { > >> > + compatible = "usb-tcpci,ptn5110"; > >> > + reg = <0x50>; > >> > + interrupt-parent = <&gpio3>; > >> > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > >> > + > >> > + usb_con: connector { > >> > >> How is the OF graph done in this case? You need some link to the USB > controller. > > > > The platform(i.MX8MQ EVK) for this is still on the way of start > > upstream, I was Planning to add this part with enabling USB3 function, > > as of how this will be done, I only have usb3 ss data(no display port or > Sideband), is something like below OK? > > > > typec: ptn5110@50 { > > compatible = "nxp,ptn5110"; > > ... > > > > usb_con: connector { > > compatible = "usb-c-connector"; > > label = "USB-C"; > > ... > > > > ports { > > #address-cells = <1>; > > #size-cells = <0>; > > > > port@1 { > > reg = <1>; > > usb_con_ss: endpoint { > > remote-endpoint = <&usb3_phy_ss>; > > }; > > }; > > }; > > }; > > }; > > > > &usb3_phy0 { > > status = "okay"; > > > > port { > > usb3_phy_ss: endpoint { > > Normally, the graph connection would be to the USB controller, not the phy as > the phy is just referred to with a "phys" property. Understood, I will put this into a USB controller node. Thanks. Jun > > > remote-endpoint = <&usb_con_ss>; > > }; > > }; > > } ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
