RE: [PATCH 5/6] USB: renesas_usbhs: drop support for legacy phys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> From: Johan Hovold, Sent: Saturday, April 14, 2018 10:06 PM
> 
> Drop support for legacy phys which hasn't been used with a mainline
> kernel since commit 9080b8dc761a ("ARM: OMAP2+: Remove legacy usb-host.c
> platform init code"). Specifically, since that commit usb_get_phy_dev()
> have always returned -ENODEV and consequently this code has not been
> used.
> 
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> ---
>  drivers/usb/renesas_usbhs/common.h |  1 -
>  drivers/usb/renesas_usbhs/rcar2.c  | 29 -----------------------------
>  2 files changed, 30 deletions(-)

Thank you for the patch!
The drivers/usb/renesas_usbhs/mod_gadget.c still uses the legacy phy API (usb_get_phy()).
Also this patch set doesn't drop the API. So, I think this subject should be changed.
What do you think?

Dropping usb_get_phy_dev() from this driver is good to me.

Best regards,
Yoshihiro Shimoda

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux