Hi Rodrigo, On 4/16/2018 7:27 PM, Rodrigo Stuffs wrote: > Hi there Minas / linux-usb ; > > I have a good ole APC Back-UPS ES 600N that from time to time resolves > that it should stop talking to my SBCs. > > This issue happened in my Raspberry Pi, and when it stopped I had the > following printk: > > Apr 11 14:10:15 localhost kernel: [9416331.806123] hid-generic > 0003:051D:0002.000A: usb_submit_urb(ctrl) failed: -1 > > All I had to do is monitor the graphics and when it flatlined, unplug > and plug the UPS usb port. Until the next occurrence. Well, I lived > with it for some good years. > > Last weekend I changed the Raspberry Pi with a TinkerBoard. And the > cranky UPS is also tickling TinkerBoard's USB port. Now the issue > manifests in a slightly different way: > > == DEVICE ENUMERATION == > [56529.462106] usb 1-1.1.3: new low-speed USB device number 9 using dwc2 > [56530.222538] usb 1-1.1.3: New USB device found, idVendor=051d, idProduct=0002 > [56530.222638] usb 1-1.1.3: New USB device strings: Mfr=3, Product=1, > SerialNumber=2 > [56530.222697] usb 1-1.1.3: Product: Back-UPS ES 600N FW:876.Q1j.D USB FW:Q1j > [56530.222772] usb 1-1.1.3: Manufacturer: APC > [56530.222821] usb 1-1.1.3: SerialNumber: 5B1017T20483 > [56535.075030] hid-generic 0003:051D:0002.0003: hiddev0,hidraw1: USB > HID v1.10 Device [APC Back-UPS ES 600N FW:876.Q1j.D USB FW:Q1j] on > usb-ff540000.usb-1.1.3/input0 > > == KERNEL WHINES == > [105243.156331] dwc2 ff540000.usb: dwc2_hc_chhltd_intr_dma: Channel 11 > - ChHltd set, but reason is unknown > [105243.156414] dwc2 ff540000.usb: hcint 0x00000002, intsts 0x06600029 > [105273.536188] dwc2 ff540000.usb: dwc2_hc_chhltd_intr_dma: Channel 13 > - ChHltd set, but reason is unknown > [105273.536268] dwc2 ff540000.usb: hcint 0x00000002, intsts 0x06600029 > > Well, in spirit to getting things going nicely in the new system, I > have found the thread: > https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinics.net_lists_linux-2Dusb_msg161854.html&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=cQBKt4q-qzNVC53rNAwuwplH23V61rHQhhULvdLA0U8&m=YSUQg6kIP4Y-Gp3eOPRqJsOKFEqJhfwK5i4u4G3GSx4&s=dlmTJf4doonVjjhkGKKAInIpIaKQuPrpIpmCm5eEKGM&e= > > Where Minas suggests a patch to tackle it. > > I tried to backport the patch to my 4.4 Kernel and it was not really > happy about it: > > == COMPILE BARFS == > CC drivers/usb/dwc2/hcd.o > drivers/usb/dwc2/hcd.c: In function ‘dwc2_core_init’: > drivers/usb/dwc2/hcd.c:2191:22: error: ‘trdtrim’ undeclared (first use > in this function); did you mean ‘strstrip’? > u32 usbcfg, otgctl; trdtrim; Your backport is wrong, you used semicolon instead of comma. Should be: u32 usbcfg, otgctl, trdtrim; Thanks, Minas > ^~~~~~~ > strstrip > drivers/usb/dwc2/hcd.c:2191:22: note: each undeclared identifier is > reported only once for each function it appears in > drivers/usb/dwc2/hcd.c:2192:2: warning: ISO C90 forbids mixed > declarations and code [-Wdeclaration-after-statement] > error, forbidden warning: hcd.c:2192 > scripts/Makefile.build:277: recipe for target 'drivers/usb/dwc2/hcd.o' failed > make[3]: *** [drivers/usb/dwc2/hcd.o] Error 1 > scripts/Makefile.build:484: recipe for target 'drivers/usb/dwc2' failed > make[2]: *** [drivers/usb/dwc2] Error 2 > scripts/Makefile.build:484: recipe for target 'drivers/usb' failed > make[1]: *** [drivers/usb] Error 2 > Makefile:1016: recipe for target 'drivers' failed > make: *** [drivers] Error 2 > > <grins> > > Patchset: https://urldefense.proofpoint.com/v2/url?u=https-3A__pastebin.com_v1ink6fJ&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=cQBKt4q-qzNVC53rNAwuwplH23V61rHQhhULvdLA0U8&m=YSUQg6kIP4Y-Gp3eOPRqJsOKFEqJhfwK5i4u4G3GSx4&s=c0BOzNW40WKgpIngxNKxkJ4qY2bN3h7R2a2DnIBLv3Q&e= > > == QUESTIONS == > 1. What are the odds that the OP patchset will also help my issue? > 2. IF 1 == true ; then what am I doing wrong in my patch? :-) > > Appreciate your time. > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
