Hi Guenter, > -----Original Message----- > From: Guenter Roeck [mailto:groeck7@xxxxxxxxx] On Behalf Of Guenter Roeck > Sent: 2018年4月14日 11:03 > To: Jun Li <jun.li@xxxxxxx> > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > heikki.krogerus@xxxxxxxxxxxxxxx; hdegoede@xxxxxxxxxx; rmfrfs@xxxxxxxxx; > yueyao.zhu@xxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; dl-linux-imx > <linux-imx@xxxxxxx> > Subject: Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-* > properties > > On 04/13/2018 04:31 PM, Jun Li wrote: > > > >> -----Original Message----- > >> From: Guenter Roeck [mailto:linux@xxxxxxxxxxxx] > >> Sent: 2018年4月14日 0:04 > >> To: Jun Li <jun.li@xxxxxxx> > >> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > >> heikki.krogerus@xxxxxxxxxxxxxxx; hdegoede@xxxxxxxxxx; > >> rmfrfs@xxxxxxxxx; yueyao.zhu@xxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > >> dl-linux-imx <linux-imx@xxxxxxx> > >> Subject: Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove > >> max-sink-* properties > >> > >> On Fri, Apr 13, 2018 at 10:18:43PM +0800, Li Jun wrote: > >>> Remove max-sink-* properties since they are deprecated. > >>> > >>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > >>> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > >>> Signed-off-by: Li Jun <jun.li@xxxxxxx> > >>> --- > >>> Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 ------ > >>> 1 file changed, 6 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt > >> b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt > >>> index 472facf..6087dc7 100644 > >>> --- a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt > >>> +++ b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt > >>> @@ -6,12 +6,6 @@ Required properties : > >>> - interrupts : Interrupt specifier > >>> > >>> Optional properties : > >>> -- fcs,max-sink-microvolt : Maximum voltage to negotiate when > >>> configured as > >> sink > >>> -- fcs,max-sink-microamp : Maximum current to negotiate when > >>> configured > >> as sink > >>> -- fcs,max-sink-microwatt : Maximum power to negotiate when > >>> configured as > >> sink > >>> - If this is less then max-sink-microvolt * > >>> - max-sink-microamp then the configured current will > >>> - be clamped. > >> > >> Is it acceptable to just remove properties ? > > > > What else you suggest I should do? also add document here to explain > > why remove them? > > > I would suggest to either wait for Rob's feedback or check how other bindings > handle deprecated properties. Rob already reviewed this patch and gave his reviewed-by[1], you can see it in the patch tags. [1]https://www.spinics.net/lists/devicetree/msg221601.html Thanks Jun > > Guenter ?韬{.n?????%??檩??w?{.n???{炳???骅w* jg????????G??⒏ ⒎?:+v???????? ????＂??????
