On 13 April 2018 11:51:28 AM IST, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: >On Fri, Apr 13, 2018 at 08:12:31AM +0530, Harsh Shandilya wrote: >> On 13 April 2018 5:59:51 AM IST, Greg Hackmann <ghackmann@xxxxxxxxxx> >wrote: >> >Pixel 2 field testers reported that when they tried to reboot their >> >phones with some USB devices plugged in, the reboot would get wedged >> >and >> >eventually trigger watchdog reset. Once the Pixel kernel team found >a >> >reliable repro case, they narrowed it down to this commit's 4.4.y >> >backport. Reverting the change made the issue go away. >> >> Are you allowed to make the repro steps public? I'm writing this from >> a walleye and would be grateful if I could test for this in the >> modifed tree I'm running atm. -- > >I was told the steps are pretty simple: > - reboot the phone a lot >eventually it will hang. There's a fix in the code aurora kernel tree >for this that they never sent upstream for some odd reason (they sent >the first patch, why not the second?) > >I'll go revert this for now, thanks for the patch! > >greg k-h That'd make sense, I only tried rebooting like five times before I had to run for a class. As far as CAF is concerned, I feel the not submitting upstream, working extra to write patches which have usually better variants already upstream, seems to be common. All USB changes were dropped when they merged kernel-common into msm-3.18 with no real explanation which has been an annoyance more than once during merging -stable in my fork of msm-3.18. While I understand their situation of maintaining upwards of 5 million lines of code not upstream, it still feels sloppy to not merge stable updates and do extra work instead. /* End rant */ -- Harsh Shandilya, PRJKT Development LLC -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
