Hi Andrew, On 12/04/2018 15:04, Andrew Lunn wrote: > On Thu, Apr 12, 2018 at 02:55:36PM +0100, Phil Elwell wrote: >> The Microchip LAN78XX family of devices are Ethernet controllers with >> a USB interface. Despite being discoverable devices it can be useful to >> be able to configure them from Device Tree, particularly in low-cost >> applications without an EEPROM or programmed OTP. >> >> Document the supported properties in a bindings file, adding it to >> MAINTAINERS at the same time. > > Hi Phil > > How you link an OF node to a USB device is not obvious. Could you > please include either a pointer to some binding documentation, or make > your example show it. Thanks for the feedback. Would you consider this (lifted from the Pi 3B+ Device Tree) a sufficient example? &usb { usb1@1 { compatible = "usb424,2514"; reg = <1>; #address-cells = <1>; #size-cells = <0>; usb1_1@1 { compatible = "usb424,2514"; reg = <1>; #address-cells = <1>; #size-cells = <0>; ethernet: usbether@1 { compatible = "usb424,7800"; reg = <1>; microchip,eee-enabled; microchip,tx-lpi-timer = <600>; /* non-aggressive*/ /* * led0 = 1:link1000/activity * led1 = 6:link10/100/activity */ microchip,led-modes = <1 6>; }; }; }; }; Phil -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html