Re: [PATCH] usb: gadget: f_fs: Add compat_ioctl to ep0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jerry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.16 next-20180409]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jerry-Zhang/usb-gadget-f_fs-Add-compat_ioctl-to-ep0/20180410-060430
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-s3-04100757 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb/gadget/function/f_fs.c: In function 'ffs_ep0_compat_ioctl':
>> drivers/usb/gadget/function/f_fs.c:651:13: error: 'gadget' undeclared (first use in this function); did you mean 'dget'?
     } else if (gadget && gadget->ops->compat_ioctl) {
                ^~~~~~
                dget
   drivers/usb/gadget/function/f_fs.c:651:13: note: each undeclared identifier is reported only once for each function it appears in

vim +651 drivers/usb/gadget/function/f_fs.c

   643	
   644	#ifdef CONFIG_COMPAT
   645	static long ffs_ep0_compat_ioctl(struct file *file, unsigned code, unsigned long value)
   646	{
   647		long ret;
   648	
   649		if (code == FUNCTIONFS_INTERFACE_REVMAP) {
   650			ret = ffs_ep0_ioctl(file, code, value);
 > 651		} else if (gadget && gadget->ops->compat_ioctl) {
   652			ret = gadget->ops->compat_ioctl(gadget, code, value);
   653		} else {
   654			ret = -ENOTTY;
   655		}
   656	
   657		return ret;
   658	}
   659	#endif
   660	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux