On 4/3/2018 5:10 PM, Grigor Tovmasyan wrote: > On 4/3/2018 4:41 PM, Greg Kroah-Hartman wrote: >> On Tue, Apr 03, 2018 at 03:28:22PM +0400, Grigor Tovmasyan wrote: >>> Added descriptions for all not described parameters. >>> Fix all kernel doc's warnings. >>> >>> Signed-off-by: Grigor Tovmasyan <tovmasya@xxxxxxxxxxxx> >>> --- >>> >>> Changes from version 0: >>> >>> Rebased to balbi/next. >>> Fixed new kernel-doc warnings which cames from new patches. >>> >>> --- >>> drivers/usb/dwc2/core.c | 7 ++ >>> drivers/usb/dwc2/core.h | 166 +++++++++++++++++++++++++++++++++++-------- >>> drivers/usb/dwc2/debug.h | 2 +- >>> drivers/usb/dwc2/debugfs.c | 19 ++--- >>> drivers/usb/dwc2/gadget.c | 29 +++++--- >>> drivers/usb/dwc2/hcd.c | 3 +- >>> drivers/usb/dwc2/hcd.h | 14 ++-- >>> drivers/usb/dwc2/hcd_ddma.c | 1 + >>> drivers/usb/dwc2/hcd_intr.c | 12 ++++ >>> drivers/usb/dwc2/hcd_queue.c | 5 +- >>> drivers/usb/dwc2/params.c | 8 +++ >>> drivers/usb/dwc2/pci.c | 6 ++ >>> 12 files changed, 213 insertions(+), 59 deletions(-) >>> >>> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c >>> index 18a0a1771289..179225e2da90 100644 >>> --- a/drivers/usb/dwc2/core.c >>> +++ b/drivers/usb/dwc2/core.c >>> @@ -419,6 +419,8 @@ static void dwc2_wait_for_mode(struct dwc2_hsotg *hsotg, >>> /** >>> * dwc2_iddig_filter_enabled() - Returns true if the IDDIG debounce >>> * filter is enabled. >>> + * >>> + *@hsotg: Programming view of DWC_otg controller >> >> You need a ' ' before the '@' :( > > Thanks Greg. :) One more thing. I used /scripts/kernel-doc script for checking kernel-doc warnings and it did not gave me any warning about this. > > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html