On Thu, Mar 22, 2018 at 03:40:40PM +0100, Giuseppe Lippolis wrote: > This modem is embedded on dlink dwr-921 router. > The oem configuration states: > Signed-off-by: Giuseppe Lippolis <giu.lippolis@xxxxxxxxx> > --- > drivers/net/usb/qmi_wwan.c | 3 +++ > drivers/usb/serial/option.c | 11 +++++++++++ > 2 files changed, 14 insertions(+) Please split this up in two patches; one for qmi_wwan and one for option. Note that the option blacklist-implementation has just been updated, so please respin that part against the usb-next branch of https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/ (or simply against linux-next). Some more details can be found here: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=c3a65808f04a8426481b63a4fbd9392f009f6330 > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > index 5894e3c..b1f9b0a 100644 > --- a/drivers/net/usb/qmi_wwan.c > +++ b/drivers/net/usb/qmi_wwan.c > @@ -1100,6 +1100,9 @@ static const struct usb_device_id products[] = { > {QMI_FIXED_INTF(0x0846, 0x68a2, 8)}, > {QMI_FIXED_INTF(0x12d1, 0x140c, 1)}, /* Huawei E173 */ > {QMI_FIXED_INTF(0x12d1, 0x14ac, 1)}, /* Huawei E1820 */ > + {QMI_FIXED_INTF(0x1435, 0xd181, 3)}, /* Wistron NeWeb D18Q1 */ > + {QMI_FIXED_INTF(0x1435, 0xd181, 4)}, /* Wistron NeWeb D18Q1 */ > + {QMI_FIXED_INTF(0x1435, 0xd181, 5)}, /* Wistron NeWeb D18Q1 */ > {QMI_FIXED_INTF(0x16d8, 0x6003, 0)}, /* CMOTech 6003 */ > {QMI_FIXED_INTF(0x16d8, 0x6007, 0)}, /* CMOTech CHE-628S */ > {QMI_FIXED_INTF(0x16d8, 0x6008, 0)}, /* CMOTech CMU-301 */ > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index ebe51f11..5aea146 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -542,6 +542,10 @@ static void option_instat_callback(struct urb *urb); > #define WETELECOM_PRODUCT_6802 0x6802 > #define WETELECOM_PRODUCT_WMD300 0x6803 > > +/* Wistron NeWeb products */ > +#define WISTRON_NEWEB_VENDOR_ID 0x1435 > +#define WISTRON_NEWEB_PRODUCT_D18Q1 0xd181 Also please drop these defines and use and the numerical ids directly (with a comment after the entry) as you do for qmi_wwan. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
