On Tue, Mar 20, 2018 at 02:23:54AM -0700, Daniel Gimpelevich wrote: > On Tue, 2018-03-20 at 10:21 +0100, Greg KH wrote: > > On Tue, Mar 20, 2018 at 02:13:48AM -0700, Daniel Gimpelevich wrote: > > > On Tue, 2018-03-20 at 10:08 +0100, Greg KH wrote: > > > > Put the device "type" or "name" as a comment, that makes more sense > > > > and > > > > follows what almost all other drivers do. > > > > > > I strongly considered this, but I ultimately decided against it in > > > consideration of the limited space for comments on the right, the lack > > > of such device identification extant in this driver, and the presence of > > > most or all of the listed devices in the usb.ids file. > > > > There is no usb.ids file anymore :) > > The "update-usbids" command still downloads > http://www.linux-usb.org/usb.ids for me. Yes, but udev builds it into the hardware id database now directly, and I doubt any other tool relies on it anymore. 'lsusb' hasn't for quite some time. Anyway, pointless digression, can you please fix up the patch to at the least, take out the people's names from the comments in the code and resend it so that it can be applied. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
