Hi > -----Original Message----- > From: Guenter Roeck [mailto:groeck7@xxxxxxxxx] On Behalf Of Guenter > Roeck > Sent: 2018年3月15日 12:47 > To: Jun Li <jun.li@xxxxxxx> > Cc: robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; > gregkh@xxxxxxxxxxxxxxxxxxx; heikki.krogerus@xxxxxxxxxxxxxxx; > a.hajda@xxxxxxxxxxx; yueyao@xxxxxxxxxx; shufan_lee@xxxxxxxxxxx; > o_leveque@xxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; dl-linux-imx > <linux-imx@xxxxxxx> > Subject: Re: [PATCH v3 08/12] staging: typec: tcpci: enable vbus detection > > On Tue, Mar 13, 2018 at 05:34:34PM +0800, Li Jun wrote: > > TCPCI implementation may need SW to enable VBUS detection to generate > > power status events. > > > > Signed-off-by: Li Jun <jun.li@xxxxxxx> > > Makes sense to me. Only question might be if this should be dones before > checking the power status at the beginnng of the function. Any thoughts ? > Per spec, that power status checking is to make sure the tcpc has completed Initialization and all registers are valid, I think it may not safe to issue tcpc command before that. Thanks Jun > Otherwise > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > > --- > > drivers/staging/typec/tcpci.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/staging/typec/tcpci.c > > b/drivers/staging/typec/tcpci.c index f5a3bf5..9a230c6 100644 > > --- a/drivers/staging/typec/tcpci.c > > +++ b/drivers/staging/typec/tcpci.c > > @@ -373,6 +373,12 @@ static int tcpci_init(struct tcpc_dev *tcpc) > > if (ret < 0) > > return ret; > > > > + /* Enable Vbus detection */ > > + ret = regmap_write(tcpci->regmap, TCPC_COMMAND, > > + TCPC_CMD_ENABLE_VBUS_DETECT); > > + if (ret < 0) > > + return ret; > > + > > reg = TCPC_ALERT_TX_SUCCESS | TCPC_ALERT_TX_FAILED | > > TCPC_ALERT_TX_DISCARDED | TCPC_ALERT_RX_STATUS | > > TCPC_ALERT_RX_HARD_RST | TCPC_ALERT_CC_STATUS; > > -- > > 2.7.4 > > ?韬{.n?????%??檩??w?{.n???{炳???骅w* jg????????G??⒏ ⒎?:+v???????? ????＂??????
