Hi Greg, 2018-03-16 21:29 GMT+08:00 Mats Karrman <mats.dev.list@xxxxxxxxx>: > Hi, > > On 2018-03-16 13:58, Greg KH wrote: > >> On Fri, Mar 16, 2018 at 05:12:49PM +0800, ShuFan Lee wrote: >>> >>> From: ShuFan Lee <shufan_lee@xxxxxxxxxxx> >>> >>> Richtek RT1711H Type-C chip driver that works with >>> Type-C Port Controller Manager to provide USB PD and >>> USB Type-C functionalities. >>> Add definition of TCPC_CC_STATUS_TOGGLING. >>> >>> Signed-off-by: ShuFan Lee <shufan_lee@xxxxxxxxxxx> >>> --- >>> drivers/staging/typec/Kconfig | 8 + >>> drivers/staging/typec/Makefile | 1 + >>> drivers/staging/typec/tcpci.h | 1 + >>> drivers/staging/typec/tcpci_rt1711h.c | 344 >>> ++++++++++++++++++++++++++++++++++ >>> 4 files changed, 354 insertions(+) >>> create mode 100644 drivers/staging/typec/tcpci_rt1711h.c >> >> This looks nice and simple to me, any reason it has to live in >> drivers/staging/ and we can't just move it to drivers/usb/typec/ now? >> >> Or are there still api things that need to be resolved with the existing >> drivers/staging/typec/ code? > > > For one thing it depends on the tcpci driver that is still in staging until > Jun Li's patches, [1], comes through. > > // Mats > > [1] https://marc.info/?l=linux-usb&m=152093458605648&w=2 > >> thanks, >> >> greg k-h >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > Just like Mats said. Because tcpci_rt1711h.c depends on tcpci driver. I'm not sure if I can put it to drivers/usb/typec/. So, I put it staging first and move out after Jun's patches. -- Best Regards, 書帆 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html