On 03/14/2018 04:27 PM, Oliver Neukum wrote: > Am Mittwoch, den 14.03.2018, 14:31 +0100 schrieb Richard Leitner: >> Hi Oliver, >> thank you for your feedback! >> >> On 03/14/2018 01:17 PM, Oliver Neukum wrote: >>> Am Mittwoch, den 14.03.2018, 11:29 +0100 schrieb Richard Leitner: >>>> From: Richard Leitner <richard.leitner@xxxxxxxxxxx> >>>> >>>> Replace the hardcoded PCI vendor ID of Netlogic with a definition in >>>> pci_ids.h >>> >>> Hi, >>> >>> in general, why? >>> Does this patch generate any benefit for any developer >>> reading the source? I don't see it. Does it cause an >>> issue for anybody who has a log file with the nummerical >>> ID and needs to grep for it? Yes it does. >> >> I'll send a v2 where I also use this definition in >> arch/mips/netlogic/xlp/ instead of PCI_VENDOR_NETLOGIC from >> arch/mips/include/asm/netlogic/xlp-hal/iomap.h. >> >> Therefore it will remove this definition from the iomap.h >> and move it to pci_ids.h >> >> This will IMHO be a clear benefit as it removes a redundant >> definition. > > Well, but it does not. Removing a redundant definition is a clear > benefit. But you are not removing a definition. You are introducing > a preprocessor constant. Why? > What is its benefit? AFAIK pci_ids.h collects PCI vendor and device IDs in one single point. As the PCI vendor ID of Netlogic is used in multiple files IMHO it would be a good idea to add it to pci_ids.h and furthermore remove it from arch/mips/include/asm/netlogic/xlp-hal/iomap.h (where it's currently defined). Or am I getting things wrong? regards;richard.l -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
