On Wed, Mar 14, 2018 at 12:36:17PM +0100, Richard Leitner wrote: > > On 03/14/2018 11:48 AM, Greg KH wrote: > > On Wed, Mar 14, 2018 at 11:29:32AM +0100, Richard Leitner wrote: > >> From: Richard Leitner <richard.leitner@xxxxxxxxxxx> > >> > >> Replace the hardcoded PCI vendor ID of Netlogic with a definition in > >> pci_ids.h > > > > Why? It's only being used in one file, so it should not be in > > pci_ids.h, right? > > It's also used as PCI_VENDOR_NETLOGIC in arch/mips/netlogic/xlp/. > > Should this be replaced with PCI_VENDOR_ID_NETLOGIC from pci_ids.h? Yes, if you are going to add it to pci_ids.h, it had better be used by multiple files, otherwise it does not belong in there. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
