> -----Original Message----- > From: linux-usb-owner@xxxxxxxxxxxxxxx > [mailto:linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of Heikki Krogerus > Sent: 2018年3月14日 17:40 > To: Jun Li <jun.li@xxxxxxx> > Cc: robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; > gregkh@xxxxxxxxxxxxxxxxxxx; a.hajda@xxxxxxxxxxx; linux@xxxxxxxxxxxx; > yueyao@xxxxxxxxxx; shufan_lee@xxxxxxxxxxx; o_leveque@xxxxxxxxx; > linux-usb@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH v3 01/12] dt-bindings: connector: add properties for typec > > On Tue, Mar 13, 2018 at 05:34:27PM +0800, Li Jun wrote: > > Add bingdings supported by current typec driver, so user can pass all > > those properties via dt. > > > > Signed-off-by: Li Jun <jun.li@xxxxxxx> > > --- > > Change for v3: > > - port-type change to be power-type which only for power. > > - add data-type for data capability. > > - preferred-role change to try-power-role(bool property need 2, and user > > may add both at the same time, so still use one property but rename > > it to be try-power-role). > > - Separate basic typec and power delivery properties. > > - keep the max-sink-mv/ma/mw, and op-mw, because the counterpart driver > > code is to be back[1], to be discussed if we need those 4 setting for long > > term. > > > > [1] > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww > > .spinics.net%2Flists%2Flinux-usb%2Fmsg166366.html&data=02%7C01%7Cju > n.l > > > i%40nxp.com%7C1dd1571bd9ea4743ec6d08d5898f9d63%7C686ea1d3bc2b4 > c6fa92cd > > > 99c5c301635%7C0%7C1%7C636566172296570893&sdata=expnxYX8F5wbW > VZoZgl91JV > > shsCTVwq98OpMslMV3XE%3D&reserved=0 > > > > .../bindings/connector/usb-connector.txt | 48 > ++++++++++++++++++++++ > > 1 file changed, 48 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/connector/usb-connector.txt > > b/Documentation/devicetree/bindings/connector/usb-connector.txt > > index e1463f1..9c7fc83 100644 > > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt > > @@ -15,6 +15,35 @@ Optional properties: > > - type: size of the connector, should be specified in case of USB-A, USB-B > > non-fullsize connectors: "mini", "micro". > > > > +Optional properties for usb-c-connector: > > +- power-type: should be one of "source", "sink" or "dual"(DRP) if > > +typec > > + connector has power support. > > +- try-power-role: preferred power role if "dual"(DRP) can support > > +Try.SNK > > + or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC. > > +- data-type: should be one of "host", "device", "dual"(DRD) if typec > > + connector supports USB data. > > Why not "power-role" and "data-role" instead of "power-type" and > "data-type"? Intention is to reflect the port capability(not state), we already have power role and data role in sys ABI for current role, I have no strong preference, if you think power-role and data-role is easy to understand and proper here, I am ok to follow it. Jun > > > Thanks, > > -- > heikki > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body > of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.k > ernel.org%2Fmajordomo-info.html&data=02%7C01%7Cjun.li%40nxp.com%7C > 1dd1571bd9ea4743ec6d08d5898f9d63%7C686ea1d3bc2b4c6fa92cd99c5c30 > 1635%7C0%7C1%7C636566172296570893&sdata=iIpoPotQYRA3tCTzTGlqfXx > BFBA267L%2B4gaXINiB7Iw%3D&reserved=0 ?韬{.n?????%??檩??w?{.n???{炳???骅w* jg????????G??⒏ ⒎?:+v???????? ????＂??????
