> -----Original Message----- > From: 李書帆 [mailto:leechu729@xxxxxxxxx] > Sent: 2018年3月12日 14:57 > To: Jun Li <jun.li@xxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; > heikki.krogerus@xxxxxxxxxxxxxxx; linux@xxxxxxxxxxxx; greg@xxxxxxxxx; > shufan_lee@xxxxxxxxxxx; cy_huang@xxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v7] staging: typec: handle vendor defined part and modify > drp toggling flow > > Hi Jun, > > 2018-03-12 13:58 GMT+08:00 Jun Li <jun.li@xxxxxxx>: > > Hi > >> -----Original Message----- > >> From: 李書帆 [mailto:leechu729@xxxxxxxxx] > >> Sent: 2018年3月12日 13:22 > >> To: Jun Li <jun.li@xxxxxxx> > >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; > >> heikki.krogerus@xxxxxxxxxxxxxxx; linux@xxxxxxxxxxxx; greg@xxxxxxxxx; > >> shufan_lee@xxxxxxxxxxx; cy_huang@xxxxxxxxxxx; > >> linux-kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx > >> Subject: Re: [PATCH v7] staging: typec: handle vendor defined part > >> and modify drp toggling flow > >> > >> Hi Jun, > >> > >> Thank you. > >> > >> 2018-03-12 12:33 GMT+08:00 Jun Li <jun.li@xxxxxxx>: > >> > Hi, > >> > > >> >> +static irqreturn_t _tcpci_irq(int irq, void *dev_id) { > >> >> + struct tcpci *tcpci = dev_id; > >> >> + > >> >> + return tcpci_irq(tcpci); > >> >> +} > >> >> > >> > ... > >> > > >> >> + err = devm_request_threaded_irq(&client->dev, client->irq, NULL, > >> >> + _tcpci_irq, > >> >> IRQF_ONESHOT | > >> IRQF_TRIGGER_LOW, > >> >> - dev_name(tcpci->dev), > tcpci); > >> >> + dev_name(&client->dev), > >> >> + chip); > >> > > >> > - dev_name(&client->dev), chip); > >> > + dev_name(&client->dev), chip->tcpci); > >> > > >> > Did you ever test this patch? > >> I've tested this patch with tcpci_rt1711h.c that will be sent out for > >> reviewing in the next patch after tcpci's modification is passed. > >> Because interrupt handler is registered in tcpci_rt1711h.c, here is > >> the place I didn't notice. > > > > Understood. > > > >> The interrupt handler for tcpci.c should be modified as following: > >> static irqreturn_t _tcpci_irq(int irq, void *dev_id) { > >> - struct tcpci *tcpci = dev_id; > >> + struct tcpci_chip *chip = dev_id; > >> > >> - return tcpci_irq(tcpci); > >> + return tcpci_irq(chip->tcpci); > >> } > >> > > > > Either way is OK to fix it. > > You may send out your v8 and notify Greg to drop your v7 version. > > > > Jun Li > > May I add you in the Reported-by list? I just gave a run with your patch on my HW, so for your new version, you can directly add: Reviewed-by: Li Jun <jun.li@xxxxxxx> Tested-by: Li Jun <jun.li@xxxxxxx> > > -- > Best Regards, > 書帆 ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
