On Wednesday 15 April 2009, Matthias Kaehlcke wrote:
> Use helper functions to determine the type and direction of an endpoint
> instead of fiddling with bEndpointAddress and bmAttributes
>
> Signed-off-by: Matthias Kaehlcke <matthias@xxxxxxxxxxxx>
Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/usb/gadget/goku_udc.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget/goku_udc.c
> index de010c9..112bb40 100644
> --- a/drivers/usb/gadget/goku_udc.c
> +++ b/drivers/usb/gadget/goku_udc.c
> @@ -110,10 +110,10 @@ goku_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)
> return -EINVAL;
> if (!dev->driver || dev->gadget.speed == USB_SPEED_UNKNOWN)
> return -ESHUTDOWN;
> - if (ep->num != (desc->bEndpointAddress & 0x0f))
> + if (ep->num != usb_endpoint_num(desc))
> return -EINVAL;
>
> - switch (desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) {
> + switch (usb_endpoint_type(desc)) {
> case USB_ENDPOINT_XFER_BULK:
> case USB_ENDPOINT_XFER_INT:
> break;
> @@ -142,7 +142,7 @@ goku_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)
> /* ep1/ep2 dma direction is chosen early; it works in the other
> * direction, with pio. be cautious with out-dma.
> */
> - ep->is_in = (USB_DIR_IN & desc->bEndpointAddress) != 0;
> + ep->is_in = usb_endpoint_dir_in(desc);
> if (ep->is_in) {
> mode |= 1;
> ep->dma = (use_dma != 0) && (ep->num == UDC_MSTRD_ENDPOINT);
> --
> 1.6.2.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
