On Wednesday 15 April 2009, Matthias Kaehlcke wrote:
> Use helper functions to determine the type and direction of an endpoint
> instead of fiddling with bEndpointAddress and bmAttributes
>
> Signed-off-by: Matthias Kaehlcke <matthias@xxxxxxxxxxxx>
Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/usb/gadget/ci13xxx_udc.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/ci13xxx_udc.c b/drivers/usb/gadget/ci13xxx_udc.c
> index 3e26cad..6d3199b 100644
> --- a/drivers/usb/gadget/ci13xxx_udc.c
> +++ b/drivers/usb/gadget/ci13xxx_udc.c
> @@ -1977,9 +1977,9 @@ static int ep_enable(struct usb_ep *ep,
> if (!list_empty(&mEp->qh[mEp->dir].queue))
> warn("enabling a non-empty endpoint!");
>
> - mEp->dir = (desc->bEndpointAddress & USB_ENDPOINT_DIR_MASK) ? TX : RX;
> - mEp->num = desc->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;
> - mEp->type = desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK;
> + mEp->dir = usb_endpoint_dir_in(desc) ? TX : RX;
> + mEp->num = usb_endpoint_num(desc);
> + mEp->type = usb_endpoint_type(desc);
>
> mEp->ep.maxpacket = __constant_le16_to_cpu(desc->wMaxPacketSize);
>
> --
> 1.6.2.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
