On Wednesday 15 April 2009, Matthias Kaehlcke wrote:
> @@ -499,26 +499,24 @@ static int fsl_ep_enable(struct usb_ep *_ep,
> /* Init EPx Queue Head (Ep Capabilites field in QH
> * according to max, zlt, mult) */
> struct_ep_qh_setup(udc, (unsigned char) ep_index(ep),
> - (unsigned char) ((desc->bEndpointAddress & USB_DIR_IN)
> - ? USB_SEND : USB_RECV),
> - (unsigned char) (desc->bmAttributes
> - & USB_ENDPOINT_XFERTYPE_MASK),
> + (unsigned char) (usb_endpoint_dir_in(desc)
> + ? USB_SEND : USB_RECV),
> + (unsigned char) (usb_endpoint_type(desc)),
> max, zlt, mult);
Again, you broke the indentation. Here, by aligning to paren
instead of just using tabs ...
>
> /* Init endpoint ctrl register */
> dr_ep_setup((unsigned char) ep_index(ep),
> - (unsigned char) ((desc->bEndpointAddress & USB_DIR_IN)
> - ? USB_SEND : USB_RECV),
> - (unsigned char) (desc->bmAttributes
> - & USB_ENDPOINT_XFERTYPE_MASK));
> + (unsigned char) (usb_endpoint_dir_in(desc)
> + ? USB_SEND : USB_RECV),
> + (unsigned char) (usb_endpoint_type(desc)));
.... ditto ...
>
> spin_unlock_irqrestore(&udc->lock, flags);
> retval = 0;
>
> VDBG("enabled %s (ep%d%s) maxpacket %d",ep->ep.name,
> - ep->desc->bEndpointAddress & 0x0f,
> - (desc->bEndpointAddress & USB_DIR_IN)
> - ? "in" : "out", max);
> + ep->desc->bEndpointAddress & 0x0f,
> + usb_endpoint_dir_in(desc)
> + ? "in" : "out", max);
.... ditto ...
> en_done:
> return retval;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
