Hi,
On 16-02-18 12:07, Andy Shevchenko wrote:
On Fri, Feb 16, 2018 at 12:47 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
In order to allow the USB Type-C Class driver take care of
things like muxes and other possible dependencies for the
port drivers, returning ERR_PTR instead of NULL from the
registration functions in case of failure.
The reason for taking over control of the muxes for example
is because handling them in the port drivers would be just
boilerplate.
void typec_unregister_altmode(struct typec_altmode *alt)
{
- if (alt)
- device_unregister(&alt->dev);
+ device_unregister(&alt->dev);
}
But it's a pattern to guarantee that unregister type of functions are
NULL (or ERR_PTR) aware.
Agreed this needs an if (!IS_ERR_OR_NULL()), will fix for v2.
Regards,
Hans
void typec_unregister_partner(struct typec_partner *partner)
{
- if (partner)
- device_unregister(&partner->dev);
+ device_unregister(&partner->dev);
}
Ditto.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
