On Wed, 14 Feb 2018, Souptick Joarder wrote:
> Use dma_pool_zalloc() instead of dma_pool_alloc + memset
>
> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
> ---
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> drivers/usb/host/ehci-mem.c | 3 +--
> drivers/usb/host/ehci-sched.c | 6 ++----
> 2 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-mem.c b/drivers/usb/host/ehci-mem.c
> index 21307d8..4c6c08b 100644
> --- a/drivers/usb/host/ehci-mem.c
> +++ b/drivers/usb/host/ehci-mem.c
> @@ -73,10 +73,9 @@ static struct ehci_qh *ehci_qh_alloc (struct ehci_hcd *ehci, gfp_t flags)
> if (!qh)
> goto done;
> qh->hw = (struct ehci_qh_hw *)
> - dma_pool_alloc(ehci->qh_pool, flags, &dma);
> + dma_pool_zalloc(ehci->qh_pool, flags, &dma);
> if (!qh->hw)
> goto fail;
> - memset(qh->hw, 0, sizeof *qh->hw);
> qh->qh_dma = dma;
> // INIT_LIST_HEAD (&qh->qh_list);
> INIT_LIST_HEAD (&qh->qtd_list);
> diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
> index e56db44..28e2a33 100644
> --- a/drivers/usb/host/ehci-sched.c
> +++ b/drivers/usb/host/ehci-sched.c
> @@ -1287,7 +1287,7 @@ static void scan_intr(struct ehci_hcd *ehci)
> } else {
> alloc_itd:
> spin_unlock_irqrestore(&ehci->lock, flags);
> - itd = dma_pool_alloc(ehci->itd_pool, mem_flags,
> + itd = dma_pool_zalloc(ehci->itd_pool, mem_flags,
> &itd_dma);
> spin_lock_irqsave(&ehci->lock, flags);
> if (!itd) {
> @@ -1297,7 +1297,6 @@ static void scan_intr(struct ehci_hcd *ehci)
> }
> }
>
> - memset(itd, 0, sizeof(*itd));
> itd->itd_dma = itd_dma;
> itd->frame = NO_FRAME;
> list_add(&itd->itd_list, &sched->td_list);
> @@ -2081,7 +2080,7 @@ static int itd_submit(struct ehci_hcd *ehci, struct urb *urb,
> } else {
> alloc_sitd:
> spin_unlock_irqrestore(&ehci->lock, flags);
> - sitd = dma_pool_alloc(ehci->sitd_pool, mem_flags,
> + sitd = dma_pool_zalloc(ehci->sitd_pool, mem_flags,
> &sitd_dma);
> spin_lock_irqsave(&ehci->lock, flags);
> if (!sitd) {
> @@ -2091,7 +2090,6 @@ static int itd_submit(struct ehci_hcd *ehci, struct urb *urb,
> }
> }
>
> - memset(sitd, 0, sizeof(*sitd));
> sitd->sitd_dma = sitd_dma;
> sitd->frame = NO_FRAME;
> list_add(&sitd->sitd_list, &iso_sched->td_list);
> --
> 1.9.1
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
