> -----Original Message----- > From: Fabio Estevam [mailto:festevam@xxxxxxxxx] > Sent: 2018年2月12日 10:24 > To: balbi@xxxxxxxxxx > Cc: Peter Chen <peter.chen@xxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; Jun Li > <jun.li@xxxxxxx>; Fabio Estevam <fabio.estevam@xxxxxxx> > Subject: [PATCH v2] usb: phy: mxs: Staticize > mxs_charger_secondary_detection() > > From: Fabio Estevam <fabio.estevam@xxxxxxx> > > mxs_charger_secondary_detection() is only used in this file, so make it > static. > > This fixes the following sparse warning: > > drivers/usb/phy/phy-mxs-usb.c:581:23: warning: symbol > 'mxs_charger_secondary_detection' was not declared. Should it be static? > > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx> > --- > Changes since v1: > - Fix typo in teh Subject (Staticize) > > drivers/usb/phy/phy-mxs-usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c > index da031c4..67371a2 100644 > --- a/drivers/usb/phy/phy-mxs-usb.c > +++ b/drivers/usb/phy/phy-mxs-usb.c > @@ -578,7 +578,7 @@ static enum usb_charger_type > mxs_charger_primary_detection(struct mxs_phy *x) > * It must be called after DP is pulled up, which is used to > * differentiate DCP and CDP. > */ > -enum usb_charger_type mxs_charger_secondary_detection(struct mxs_phy > *x) > +static enum usb_charger_type mxs_charger_secondary_detection(struct > +mxs_phy *x) > { > struct regmap *regmap = x->regmap_anatop; > int val; > -- > 2.7.4 Acked-by: Jun Li <jun.li@xxxxxxx> ?韬{.n?????%??檩??w?{.n???{炳???骅w* jg????????G??⒏ ⒎?:+v???????? ????＂??????
