On Wed, Feb 07, 2018 at 02:55:35PM +0100, Linus Walleij wrote: > On Thu, Feb 1, 2018 at 10:34 AM, Ludovic Desroches > <ludovic.desroches@xxxxxxxxxxxxx> wrote: > > > Use GPIO descriptors instead of relying on the old method. > > Include irq.h header since it is needed and was indirectly > > included through of_gpio.h. > > > > Signed-off-by: Ludovic Desroches <ludovic.desroches@xxxxxxxxxxxxx> > > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Thank you for doing gpiod conversions. Making the world > a better place! Thanks, I wish it would be so easy! I will send a v2 because I have the same issue that the one pointed by Andy about the gpiod conversion for the lcd driver. - udc->vbus_pin = devm_gpiod_get_optional(&pdev->dev, "atmel,vbus", GPIOD_IN); + udc->vbus_pin = devm_gpiod_get(&pdev->dev, "atmel,vbus", GPIOD_IN); + if (IS_ERR(udc->vbus_pin)) + udc->vbus_pin = NULL; I am not sure if I should prefer devm_gpiod_get_optional or devm_gpiod_get. Regards Ludovic -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
