Re: [PATCH] usb: gadget: core: Fix use-after-free of usb_request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felipe,

On 12/21/2017 9:54 AM, Manu Gautam wrote:
> Driver is tracing usb_request after freeing it.
> Fix it by changing the order.

Let me know if following change looks ok?

>
> Signed-off-by: Manu Gautam <mgautam@xxxxxxxxxxxxxx>
> ---
>  drivers/usb/gadget/udc/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index d41d07a..ab0a075 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -191,8 +191,8 @@ struct usb_request *usb_ep_alloc_request(struct usb_ep *ep,
>  void usb_ep_free_request(struct usb_ep *ep,
>  				       struct usb_request *req)
>  {
> -	ep->ops->free_request(ep, req);
>  	trace_usb_ep_free_request(ep, req, 0);
> +	ep->ops->free_request(ep, req);
>  }
>  EXPORT_SYMBOL_GPL(usb_ep_free_request);
>  

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux