On Mon, Jan 22, 2018 at 03:58:45PM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81232 can do remote wakeup via RX/RI pin with pulse. > This patch will use device_set_wakeup_enable to enable this > feature. This is a policy decision that should be made by user space by setting the power/wakeup attribute, and not something that something that drivers should enable directly themselves. Perhaps you really wanted to use device_set_wakeup_capable()? But then you also need to honour the current setting in suspend() as well. How have you tested this feature? Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html