Re: [PATCH v3 08/15] usb: dwc3: Make TX/RX threshold configurable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 1/29/2018 10:46 AM, Rob Herring wrote:
> On Wed, Jan 17, 2018 at 05:57:15PM -0800, Thinh Nguyen wrote:
>> DWC_usb31 periodic transfer at 48K+ bytes per interval may need
>> modification to the TX/RX packet threshold to achieve optimal result.
>> Add properties to make it configurable.
>>
>> Cc: John Youn <johnyoun@xxxxxxxxxxxx>
>> Signed-off-by: Thinh Nguyen <thinhn@xxxxxxxxxxxx>
>> ---
>>   Documentation/devicetree/bindings/usb/dwc3.txt | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
>> index 52fb41046b34..a532fa6bf884 100644
>> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
>> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
>> @@ -55,6 +55,10 @@ Optional properties:
>>    - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ
>>   	register for post-silicon frame length adjustment when the
>>   	fladj_30mhz_sdbnd signal is invalid or incorrect.
>> + - snps,rx-thr-num-pkt-prd: periodic ESS RX packet threshold count.
>> + - snps,rx-max-burst-prd: Max periodic ESS RX burst size.
>> + - snps,tx-thr-num-pkt-prd: periodic ESS TX packet threshold count.
>> + - snps,tx-max-burst-prd: Max periodic ESS TX burst size.
> 
> What are the defaults if not set?
> 

By default, periodic ESS TX and RX threshold are not enabled. To enable 
TX or RX threshold, both packet threshold count and max burst size must 
be set to a non-zero value.

Unfortunately, I did not document it in this file after I made a change 
to remove the enabling of TX/RX threshold property. I can update this 
patch series with this information. Thanks.

BR,
Thinh
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux