Am Mittwoch 08 April 2009 22:43:50 schrieb Alan Stern: > Oliver: > > I'm still not entirely satisfied with my usbserial patch. Don't you > think serial->disc_mutex should be held while serial->type->open() is > called? After all, the open methods often do submit URBs. In contrast to the autopm stuff, that's a matter of taste, not correctness. I think the idea is good. I do however think that whatever choice you make, it should be clearly documented with a comment in the header file. You wrote the patch, you decide. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html