On 24/01/2018 at 16:43, Michael Nazzareno Trimarchi wrote: > On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau <benoit@xxxxxxxxxxx> wrote: >> On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: >>> On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: >>>> On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote: >>>>> On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi >>>>> <michael@xxxxxxxxxxxxxxxxxxxx> wrote: >>>>>> SION bit should be used in the situation that we need >>>>>> to read back the value of a pin and should be set by >>>>>> default. >>> >>> You remove this bit because it should be set by default? This sentence is >>> confusing. > > English is wrong ;) > > SION bit as a specific purpose to read back value that is set in > output. You don't need > and it's not set in any freescale board. If you need to set you need > to add to your peripheral. Unless there is a NEW_PAD_CTRL()-like mechanism for SION, all these definitions should be kept in iomux-mx25.h in order not to redefine the register offsets everywhere. AFAIK, all the Freescale boards use the definitions from iomux-mx25.h too. > The only case you need maybe is the data[0] of sdcard. And eSDHC CMD, and I²C probably too. Yet, you are also removing SION in these cases. I have 3 i.M25-based boards working fine with SION. ;) Can you explain the precise issue that you are trying to fix (which pin)? Best regards, Benoît -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
