On Fri, Apr 10, 2009 at 4:50 PM, Guennadi Liakhovetski <lg@xxxxxxx> wrote: > On Fri, 10 Apr 2009, Li Yang-R58472 wrote: > >> > This patch adds support for i.MX3x (only tested with i.MX31 >> > so far) ARM >> > SoCs to the fsl_usb2_udc driver. It also moves PHY >> > configuration before >> > controller reset, because otherwise an ULPI PHY doesn't get a >> > reset and >> > doesn't function after a reboot. The problem with longer >> > control transfers >> > is still not fixed. The patch renames the fsl_usb2_udc.c file to >> > fsl_udc_core.c to preserve the same module name for user-space >> > backwards compatibility. >> > >> > Signed-off-by: Guennadi Liakhovetski <lg@xxxxxxx> >> > --- >> > >> > Platform bindings will be submitted later, when the ARM and MXC trees >> > stabilise a bit for 2.6.31:-) Thanks to Sascha Hauer for the >> > idea with >> > the USB clock on i.MX31. >> >> The patch looks good over all. But I suggest to apply it after the MXC >> platform binding patch. Without it this patch will break MXC allconfigs >> build. > > Why should it break it? The driver will be selected, it will be built, but > it won't be probed, because the platform data is missing, so, I don't see > any harm. The fsl_mx3_udc.c is missing. I assume that it is the platform binding you talked about. - Leo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html