On Wed, Jan 17, 2018 at 12:33:23AM +0530, Shreeya Patel wrote: > Change the conditional operator to assignment as it is > not a conditional statement. > > Signed-off-by: Shreeya Patel <shreeya.patel23498@xxxxxxxxx> > --- > > Changes in v2 > -Rebase and resend. > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c > index 00b20c0..314b31f 100644 > --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c > +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c > @@ -460,7 +460,7 @@ static u32 sdio_read_port( > if (mem == NULL) { > DBG_8192C(KERN_WARNING "%s: allocate memory %d bytes fail!\n", __func__, cnt); > mem = oldmem; > - oldmem == NULL; > + oldmem = NULL; > } > #else This bug would cause a GCC warning if it were ever compiled. This ifdefed code is dead. We should just delete it. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html