On Wednesday 08 April 2009, Dan Streetman wrote:
>
> This is a resend of this patch, I previously sent an email on 3/27 but got no
> response. James Kung pointed out this bug to me.
>
> The -1 appears to be a bug that prevents checking the last fully used uframe for
> a split isoc transfer. The code currently does not check the last fully used
> uframe of a multi-uframe fullspeed isoc transfer. This patch changes it to
> check each fully used uframe of a multi-uframe fullspeed isoc transfer.
>
> David, Greg, I believe this patch should be applied, do you agree?
Seems plausible to me. Do we have confirmation that it fixes
anything, or is this "theoretical" in that sense?
I don't have time to dig back into the TT scheduling morass,
so I don't recall why the "-1" is there.
> Signed-off-by: Dan Streetman <ddstreet@xxxxxxxx>
>
>
> --- linux-2.6.29/drivers/usb/host/ehci-sched.c 2009-03-23 19:12:14.000000000 -0400
> +++ b/drivers/usb/host/ehci-sched.c 2009-03-27 17:11:07.000000000 -0400
> @@ -323,7 +323,7 @@ static int tt_available (
> * already scheduled transactions
> */
> if (125 < usecs) {
> - int ufs = (usecs / 125) - 1;
> + int ufs = (usecs / 125);
> int i;
> for (i = uframe; i < (uframe + ufs) && i < 8; i++)
> if (0 < tt_usecs[i]) {
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
