On Sat, Jan 06, 2018 at 08:15:22PM +0300, Mikhail Zaytsev wrote: > The patch moves TIOCGSERIAL ioctl case to get_serial_info function. > > Signed-off-by: Mikhail Zaytsev <flashed@xxxxxxx> > static int ark3116_ioctl(struct tty_struct *tty, > unsigned int cmd, unsigned long arg) > { > struct usb_serial_port *port = tty->driver_data; > - struct serial_struct serstruct; > - void __user *user_arg = (void __user *)arg; I prefer keeping this pointer here to avoid adding casts to every helper function call, so I added it back before applying. > > switch (cmd) { > case TIOCGSERIAL: > + return ark3116_get_serial_info(port, > + (struct serial_struct __user *)arg); Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html