RE: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, January 05, 2018, Sergei Shtylyov wrote:
> > +	usbhs0: usbhs@e8010000 {
> 
>     The node names should be generic, i.e "usb@e8010000".
> 
> > +		compatible = "renesas,usbhs-r7s72100";
> > +		reg = <0xe8010000 0x1A0>;
> 
>     Lowercase in the hex values, please be consistent...
> 
> > +		interrupts = <GIC_SPI (73-32) IRQ_TYPE_LEVEL_HIGH>;
> > +		clocks = <&mstp7_clks R7S72100_CLK_USB0>;
> > +		renesas,buswait = <4>;
> > +		power-domains = <&cpg_clocks>;
> > +		status = "disabled";
> > +	};
> > +
> > +	usbhs1: usbhs@e8207000 {
> > +		compatible = "renesas,usbhs-r7s72100";
> > +		reg = <0xe8207000 0x1A0>;
> > +		interrupts = <GIC_SPI (74-32) IRQ_TYPE_LEVEL_HIGH>;
> > +		clocks = <&mstp7_clks R7S72100_CLK_USB1>;
> > +		renesas,buswait = <4>;
> > +		power-domains = <&cpg_clocks>;
> > +		status = "disabled";
> > +	};
> >   };
> 
>     The same comments for the 2nd device.

Thank you for the review.

I'll make the changes and resubmit.

Chris

��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux