On Wed, 3 Jan 2018 13:08:12 -0800 Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > + mutex_lock(&rp->fetch_lock); > > offset = vmf->pgoff << PAGE_SHIFT; > > if (offset >= rp->b_size) > > + mutex_unlock(&rp->fetch_lock); > > return VM_FAULT_SIGBUS; > > chunk_idx = offset / CHUNK_SIZE; > > missing braces ... maybe you'd rather a 'goto sigbus' approach? Thanks. What a way to return to kernel programming for me. I'm going to test it anyway, already started to unpacking a PC, but yeah... -- Pete -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html