On Tue, Apr 07, 2009 at 01:42:03PM -0500, Mike Isely wrote: > On Tue, 7 Apr 2009, Greg KH wrote: > > > On Tue, Apr 07, 2009 at 05:31:55PM +0000, David Vrabel wrote: > > > Wireless USB endpoint state has a sequence number and a current > > > window and not just a single toggle bit. So allow HCDs to provide a > > > endpoint_reset method and call this or clear the software toggles as > > > required (after a clear halt). > > > > > > usb_settoggle() and friends are then HCD internal and are moved into > > > core/hcd.h. > > > > You remove this api, yet the pvrusb2 driver used it, and you don't seem > > to have resolved the issue where it was calling it: > > > > > diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c > > > index fa304e5..b86682d 100644 > > > --- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c > > > +++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c > > > @@ -1418,7 +1418,6 @@ static int pvr2_upload_firmware1(struct pvr2_hdw *hdw) > > > return ret; > > > } > > > > > > - usb_settoggle(hdw->usb_dev, 0 & 0xf, !(0 & USB_DIR_IN), 0); > > > usb_clear_halt(hdw->usb_dev, usb_sndbulkpipe(hdw->usb_dev, 0 & 0x7f)); > > > > > > pipe = usb_sndctrlpipe(hdw->usb_dev, 0); > > > > Should usb_reset_endpoint() be called here instead? > > > > Speaking as the maintainer of that driver, I'm OK with accepting this > as-is for now. This is a sequence that should not interfere with normal > driver operation. I will look at this further a little later (not > likely before the merge window closes) and if this change turns out to > cause a problem I'll make a follow-up fix upstream. > > Acked-By: Mike Isely <isely@xxxxxxxxx> Great, thanks for letting me know. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
