Re: Mutex deadlock from garmin_close in garmin_gps.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Montag 06 April 2009 17:02:19 schrieb Alan Stern:
> > > BTW, I'm concerned about that usb-serial.c patch posted earlier.  In
> > > particular, does serial_open() hold disc_mutex long enough?  What
> > > happens if a disconnect occurs while serial_open() is waiting to
> > > acquire port->mutex?  Do you think the calls to
> > > usb_autopm_get_interface() and serial->type->open() should also be
> > > protected by disc_mutex?
> >
> > Yes. usb_autopm_get_interface() must be protected or the counters get out
> > of sync.
>
> Here's an updated version of that patch.  See what you think.

It looks correct to me.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux