On Mon, Dec 11, 2017 at 09:48:00PM +0100, Bjørn Mork wrote:
> Reinhard Speyerer <rspmn@xxxxxxxx> writes:
>
> > Sierra Wireless EM7565 devices use the DEVICE_SWI layout for their
> > serial ports
> >
> > T: Bus=01 Lev=03 Prnt=29 Port=01 Cnt=02 Dev#= 31 Spd=480 MxCh= 0
> > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> > P: Vendor=1199 ProdID=9091 Rev= 0.06
> > S: Manufacturer=Sierra Wireless, Incorporated
> > S: Product=Sierra Wireless EM7565 Qualcomm Snapdragon X16 LTE-A
> > S: SerialNumber=xxxxxxxx
> > C:* #Ifs= 4 Cfg#= 1 Atr=a0 MxPwr=500mA
> > I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=qcserial
> > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=qcserial
> > E: Ad=83(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
> > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=qcserial
> > E: Ad=85(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
> > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 8 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> > E: Ad=86(I) Atr=03(Int.) MxPS= 8 Ivl=32ms
> > E: Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=0f(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> >
> > but need sendsetup = true for the GPS port to make it work properly.
> > Add a new DEVICE_SW2 layout variant and use it for the EM7565 PID 0x9091.
> > Add a DEVICE_SWI entry for the EM7565 QDL PID 0x9090.
>
> I wonder if the new variant is strictly necessary? I got a feeling that
> the old behaviour is arbitrary, and that older Sierra devices might work
> both with and without sendsetup too.
>
> Did you try sendsetup on the NMEA port with any older Sierra device?
>
> I just did a quick test on the EM7455 in my laptop, and it doesn't seem
> to mind at least.
>
>
> Bjørn
Hi Bjørn,
following your suggestion I used this patch for testing:
--- drivers/usb/serial/qcserial.c.orig 2017-07-27 18:10:39.000000000 -0400
+++ drivers/usb/serial/qcserial.c 2017-12-13 18:02:37.946654688 -0500
@@ -167,2 +167,4 @@
{DEVICE_SWI(0x1199, 0x907b)}, /* Sierra Wireless EM74xx */
+ {DEVICE_SWI(0x1199, 0x9090)}, /* Sierra Wireless EM7565 QDL */
+ {DEVICE_SWI(0x1199, 0x9091)}, /* Sierra Wireless EM7565 */
{DEVICE_SWI(0x413c, 0x81a2)}, /* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
@@ -343,2 +345,3 @@
dev_dbg(dev, "NMEA GPS interface found\n");
+ sendsetup = true;
break;
On all of the MC77xx/MC73xx/MC74xx devices I tried and even on an old
MC8801 switched to QMI mode the NMEA port worked without problems for
me.
Besides being simpler than v1 the patch above also avoids for future
vendor-branded EM7565 variants being added to the wrong layout macro
by mistake.
I will submit a formal patch v2 based on the above later today.
Regards,
Reinhard
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
