On Mon, Apr 06, 2009 at 04:08:01PM +0200, Ajay Kumar Gupta wrote: > > > void __init usb_musb_init(void) > > > { > > > if (cpu_is_omap243x()) { > > > @@ -172,10 +159,7 @@ void __init usb_musb_init(void) > > > musb_resources[0].end = musb_resources[0].start + SZ_8K - 1; > > > > > > #ifdef CONFIG_NOP_USB_XCEIV > > > - if (platform_device_register(&nop_xceiv_device) < 0) { > > > - printk(KERN_ERR "Unable to register NOP-XCEIV device\n"); > > > - return; > > > - } > > > + usb_nop_xceiv_register(); > > > > how about you move the ifdef also to the definition of > > usb_nop_xceiv_register(). It's probably in a header file somewhere so > > you: > > It is at: include/linux/usb/otg.h, > ============== > #ifdef CONFIG_NOP_USB_XCEIV > extern void usb_nop_xceiv_register(void); > extern void usb_nop_xceiv_unregister(void); > #endif > ================ > But one of the David's queued patch [1] removes the #ifdef part. > [1] http://marc.info/?l=linux-usb&m=123852883820097&w=2 > > Is it ok to add it back in this patch? > > David, what's your comment on this? if the user doesn't select the nop transceiver, I guess that symbol should become a static inline doing nothing. What do you think Dave ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html