Re: [PATCH] Revert "usb: gadget: allow to enable legacy drivers without USB_ETH"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 11, 2017 at 5:45 PM, Bart Van Assche <bart.vanassche@xxxxxxx> wrote:
> Romain Izard reported the following about commit 7a9618a22aad:
>
>     As it reached Linus' tree with v4.15-rc3, I recently noticed the
>     following commit that triggered a Kconfig request. I believe that this
>     change does not make sense.
>
>     7a9618a22aa usb: gadget: allow to enable legacy drivers without USB_ETH
>
>     USB_ETH was not a dependency, but a default value for the choice. As the
>     choice was marked as "optional", it was possible to remove this value
>     when building.
>
>     After this modification, the Kconfig choice option does not contain
>     anything anymore, so it is useless.  It is also possible to select
>     multiple built-in legacy drivers. This builds, but will not work as
>     expected as only one legacy driver can be bound to an USB device
>     controller at a time.
>
> Hence revert commit 7a9618a22aad.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> Cc: Romain Izard <romain.izard.pro@xxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Cc: Hannes Reinecke <hare@xxxxxxxx>
> Cc: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> Cc: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Cc: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>

Ok, let's use this one instead of my patch then,

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux