Re: [PATCH] USB: serial: Avoid goto in bulk callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Oliver, Johan,

On Mon, Dec 11, 2017 at 11:58:21AM +0100, Oliver Neukum wrote:
> Am Montag, den 11.12.2017, 00:11 +0100 schrieb Ladislav Michl:
> > Refactor bulk callback functions to make use of goto pointless.
> > 
> > 
> 
> Hi,
> 
> you seem to assume that this is a good thing by itself which
> needs no further justification. I disagree. You duplicated
> code.

Where did I duplicated code? Success code path is straightforward
now, so while I'm not pushing at all for this patch to be included
as it is side effect of looking into another drivers while debugging
something else, I really do not understand your comment.

On Mon, Dec 11, 2017 at 11:13:51AM +0100, Johan Hovold wrote:
> So as for the ti driver, I prefer keeping the success path out of the
> switch statement.

Undestood, as noted above, I have no strong preference either way.
Just did what seemed easier to read to me :)

Best regads,
	ladis
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux