On Mon, Dec 11, 2017 at 02:07:37AM +0300, Dmitry Osipenko wrote: > Tegra's PHY driver has a mix of pr_err() and dev_err(), let's switch to > dev_err() and use common errors message formatting across the driver for > consistency. > > Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> > --- > drivers/usb/phy/phy-tegra-usb.c | 72 +++++++++++++++++++++++++---------------- > 1 file changed, 44 insertions(+), 28 deletions(-) Can we also get rid of all the function names in error messages? I see that for some error messages you've removed them, but then for others you added them, so you remove inconsistencies on one hand and add other inconsistencies at the same time. =) Other than that, I like this. Thierry
Attachment:
signature.asc
Description: PGP signature