Re: [PATCH v2] usb: dwc2: Remove unnecessary debug prints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/7/2017 11:18 PM, Joe Perches wrote:
> On Thu, 2017-12-07 at 11:17 -0800, Joe Perches wrote:
>> On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote:
>>> Removed unnecessary debug prints about DMA mode for host side
>>> from dwc2_gahbcfg_init() function.
>>
>> What other functionality makes these unnecessary?
>> If any, it's nice to de
> 
> ... describe it in the changelog.
> 

Hi Joe,

No any other functionality makes them unnecessary.

In the driver we have debug info about DMA type only for host side, so 
operating in device mode DMA type can be different and those debug 
prints ("Using Buffer\Descriptor DMA mode\n") can cause confusions.

We can add debug prints for device mode also, but it is preferable to 
have less debug info in the log.

Thanks,
Razmik
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux