On Thu, Dec 07, 2017 at 07:24:35PM +0000, Michael Drake wrote: > On 07/12/17 17:26, Greg KH wrote: > > On Thu, Dec 07, 2017 at 05:14:10PM +0000, Michael Drake wrote: > > > On 07/12/17 15:16, Greg KH wrote: > > > > On Thu, Dec 07, 2017 at 04:01:23PM +0100, Greg KH wrote: > > > > > Oops, I should have tested the code, it now crashes for me with the > > > > > following error: > > > > > Floating point exception (core dumped) > > > > > > > > > > Do you see this as well? > > > > > > No, I don't see that. > > > > > > > And it's crashing on my USB audio device. Here's the output of it from > > > > the "old" lsusb output. > > > > > > [snip] > > > > > > Does it still crash with the warning fixes I posted? If so I'll > > > look in detail tomorrow. > > > > I will check when I get home tonight, I don't have the USB device on me > > at the moment. > > Thank you. I believe I've guessed the problem and sent a patch. Ok, that now works. But there is a difference in the "old" and "new" outputs, here's a diff of a full -v output of my laptop and a bunch of USB devices plugged in, showing the fields that now look different. The big one is the change from "streaming" to "control", is that correct? thanks, greg k-h --- lsusb-v.orig 2017-12-07 21:01:26.153185002 +0100 +++ lsusb-v.new 2017-12-07 21:01:32.806517978 +0100 @@ -1110,9 +1110,9 @@ bDescriptorType 36 bDescriptorSubtype 1 (HEADER) bcdADC 1.00 - wTotalLength 0x0028 + wTotalLength 40 bInCollection 1 - baInterfaceNr(0) 1 + baInterfaceNr( 0) 1 AudioControl Interface Descriptor: bLength 12 bDescriptorType 36 @@ -1142,10 +1142,10 @@ bUnitID 13 bSourceID 1 bControlSize 1 - bmaControls(0) 0x01 + bmaControls( 0) 0x01 Mute Control - bmaControls(1) 0x00 - bmaControls(2) 0x00 + bmaControls( 1) 0x00 + bmaControls( 2) 0x00 iFeature 0 Interface Descriptor: bLength 9 @@ -1173,7 +1173,7 @@ bDescriptorSubtype 1 (AS_GENERAL) bTerminalLink 1 bDelay 1 frames - wFormatTag 0x0001 PCM + wFormatTag 1 PCM AudioStreaming Interface Descriptor: bLength 20 bDescriptorType 36 @@ -1199,14 +1199,14 @@ bInterval 4 bRefresh 0 bSynchAddress 133 - AudioStreaming Endpoint Descriptor: + AudioControl Endpoint Descriptor: bLength 7 bDescriptorType 37 bDescriptorSubtype 1 (EP_GENERAL) bmAttributes 0x01 Sampling Frequency bLockDelayUnits 0 Undefined - wLockDelay 0x0000 + wLockDelay 0 Undefined Endpoint Descriptor: bLength 9 bDescriptorType 5 @@ -1235,7 +1235,7 @@ bDescriptorSubtype 1 (AS_GENERAL) bTerminalLink 1 bDelay 1 frames - wFormatTag 0x0001 PCM + wFormatTag 1 PCM AudioStreaming Interface Descriptor: bLength 20 bDescriptorType 36 @@ -1261,14 +1261,14 @@ bInterval 4 bRefresh 0 bSynchAddress 133 - AudioStreaming Endpoint Descriptor: + AudioControl Endpoint Descriptor: bLength 7 bDescriptorType 37 bDescriptorSubtype 1 (EP_GENERAL) bmAttributes 0x01 Sampling Frequency bLockDelayUnits 0 Undefined - wLockDelay 0x0000 + wLockDelay 0 Undefined Endpoint Descriptor: bLength 9 bDescriptorType 5 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html