On Thu, Dec 07, 2017 at 05:11:58PM +0000, Michael Drake wrote: > > > On 07/12/17 15:00, Greg KH wrote: > > On Thu, Dec 07, 2017 at 10:26:21AM +0000, Michael Drake wrote: > > > This adds a new way of dumping descriptors, which splits the knowledge > > > of how to interpret descriptor data from the actual dumping. This has > > > two advantages: > > > > > > 1. It is easy to add support for new descriptors, since they are now > > > simple definitions that resemble the tables in the USB specifications. > > > > > > 2. The code for dumping descriptors is common, so the output is easy to > > > keep consistent. It is also consistent and thorough in its handling > > > of insufficient descriptor data buffer, and junk data at the end of > > > a descriptor. > > > > > > UAC1 and UAC2 are converted to use the new mechanism, initial support > > > for UAC3 is added. Finally, support for the USB3 BOS Configuration > > > Summary Descriptor is added. > > > > > > This was previously opened as a github pull request here: > > > > > > https://github.com/gregkh/usbutils/pull/61 > > > > Thanks for this, all of the patches are now applied. > > > > There were some intermediate build warnings, but future patches in the > > series fixed that up, next time be more careful, each patch should be > > "clean". > > > > However the build now gets the following warnings: > > > > CC lsusb-lsusb.o > > lsusb.c:220:12: warning: ‘get_audioterminal_string’ defined but not used [-Wunused-function] > > static int get_audioterminal_string(char *buf, size_t size, u_int16_t termt) > > ^~~~~~~~~~~~~~~~~~~~~~~~ > > CC lsusb-lsusb-t.o > > CC lsusb-desc-defs.o > > CC lsusb-desc-dump.o > > desc-dump.c: In function ‘desc_bmcontrol_dump’: > > desc-dump.c:67:18: warning: comparison between pointer and zero character constant [-Wpointer-compare] > > if (strings[0] != '\0') { > > ^~ > > desc-dump.c:67:7: note: did you mean to dereference the pointer? > > if (strings[0] != '\0') { > > ^ > > CC lsusb-names.o > > > > > > Can you fix this up and send a patch for them? > > Done. > > Oddly I didn't see the warnings with the default `make`. I hacked > "Makefile.am" locally to add "-Wall -Wextra -pedantic -O2" to the > CCFLAGS, and I saw the one about the unused get_audioterminal_string() > function. However I still didn't see the other. > > (Using gcc (Debian 6.3.0-18) 6.3.0 20170516) It's your version of gcc, you need a more modern one: $ gcc --version gcc (GCC) 7.2.0 thanks for the fixups. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
