On Wed, Dec 06, 2017 at 04:52:37PM +0000, Michael Drake wrote: > > > On 05/12/17 16:39, Greg KH wrote: > > On Tue, Dec 05, 2017 at 04:14:28PM +0000, Michael Drake wrote: > > > --- > > > desc-defs.c | 277 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++---- > > > desc-defs.h | 3 + > > > desc-dump.c | 5 ++ > > > 3 files changed, 270 insertions(+), 15 deletions(-) > > > > We need some kind of changelog text here to describe what is going on. > > I'm happy to do this, however I'm unclear on exactly what needs > doing. (Ditto for the comments on patches 6, 7, and 8). > > The ChangeLog file has not been updated since an entry in 2009 > which I read as saying to stop updating that file: > > * switched over to git, look at the changelog there > instead of here. > > From that I assumed it meant that the `git log` would become > the ChangeLog from that point. Sorry, I mean here, in the patch itself, we need some text that git will use to add to the changelog. Like what you did on the other patches. You need some sort of text explaining what this patch does here. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
